[6.x] Adds "Set Alt" button in assets grid view #13480
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Isn't removing the checkerboard background not a problem with png images as this was just corrected in #13469 ? |
|
Hi @kjetilhole, thanks for this PR, very much appreciated! I just had a chat with the team and we think it would be better to always expose "Set Alt", without needing to hover over every image. Missing alt text is like a red flag for SEO and accessibility, so editors should want to see it sticking out for any images with missing alt. I've shifted the alt text and added it to your PR so it looks like this now
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #12592 and #13483
Added the "Set Alt" button for Assets fields when "Show filename" is disabled and UI mode is set to grid.
I removed the checkerboard background to make it easier to see the blue-colored button.The icon buttons have also been reduced from 'sm' -> 'xs' to make space for the button
Alt-text has been changed from 'blue' -> 'sky' in Assets grid view to maintain consistency.
Before
After
